timothyklemm
timothyklemm
@AttilaVamos I noticed. I also noticed that other PRs aren't failing as consistently. I don't have an explanation yet, which is why I haven't asked for any reviews.
I missed the threaded active span functionality, which can improve this implementation. Will submit an updated version.
> I think one of the main concerns has been the TxSummary lifespan is different than the active span, are we ensuring all TxSummary attributes are being forwarded/set on the...
@ghalliday this has been waiting for feedback after my last update. Now the feedback has me questioning if I understand the problem I'm attempting to solve.
Will no longer attempt to reuse instrumentation. TxSummary will remain unchanged for now. Values we want in spans will be added directly to the appropriate span.
@ghalliday ready to merge.
@ghalliday please merge.
@ghalliday this should be ready to merge.
@GordonSmith, this is a possible solution and I'm just looking for feedback initially. If acceptable, a change to LN will be required so its version.cmake can be included earlier than...
I didn't spend time trying to identify the cause, but cmake failed every time I tried to include vcpkg.cmake _after_ the project statement. It seems like everything here, and in...