Timo Stamm
Timo Stamm
Okay, it's reasonable to _not_ set the User-Agent request header if the user already provided one via `CallOptions.headers`. This applies to the Connect, gRPC, and gRPC-Web transports, but not to...
Closed by https://github.com/connectrpc/connect-es/pull/1272. It would be convenient to have a transport-level option, but we try to keep the API lean. Interceptors (as suggested in https://github.com/connectrpc/connect-es/issues/1271#issuecomment-2411048990), shouldn't have a perceivable impact...
> So, are you saying that the logic for generating the grpc-js-* string should be removed Yes. > and we should just pass the header instead? Currently, we're always setting...
To fix #1271, we can allow to pass a custom user agent via `CallOptions.headers`, which is a reasonable incremental change. We can discuss other features separately.
Thanks for the report, Vili. I don't think it's sufficient to change protovalidate's `ProtoAdapter`. There will be other places in cel-java where the same conversion happens. We enable the cel-java...
> It might be a solution to disable this option. The next cel-java release will enable the option by default. It's deprecated and will be removed in the future. This...
If a nil message is ignored by `proto.Marshal` and `protojson.Marshal`, maybe it would be least surprising to also ignore in it in protovalidate?
> It's not that it's ignored by serialization but that it gets quietly transformed into an empty message. > A nil message in a set oneof field, repeated, and (assuming)...
@stephenh, I took care of the follow-ups. This is using an alpha of @bufbuild/protobuf v2. I promise we won't break it if you want to publish as is. A stable...
A beta of `@bufbuild/protobuf` is available, and it won't be long until it's stable. I'll update this PR once the stable v2 is published.