Timo Stamm

Results 302 comments of Timo Stamm

Great use cases for this feature: - https://github.com/connectrpc/connect-es/issues/1233 - https://github.com/connectrpc/connect-es/issues/1287

Thanks for the report and the repro, Nathan. This bug has slipped in some time earlier this year before release 1.4.0 and is present on `main` and `v2`.

Hey Gurleen, we recently release version 2 of [buf.build/bufbuild/es](https://buf.build/bufbuild/es). The plugin for Connect [buf.build/connectrpc/es](https://buf.build/connectrpc/es) has not been updated to support it yet. Can you pin the versions of the plugins...

Louis, you're right that `HandlerContext.signal` takes on two different concerns with cancellation and completion. Now that `AbortSignal.any()` has been added to the standard, it has become a bit more intuitive...

V2 is mainly for compatibility with protobuf-es v2, but we can make other sensible breaking changes. It lives in the [branch v2](https://github.com/connectrpc/connect-es/tree/v2), and is available as a [pre-release](https://github.com/connectrpc/connect-es/releases/tag/v2.0.0-alpha.1). Once v2...

To split up the concerns, we could add a separate signal to the handler for completion, and/or a separate combined signal (basically renaming the current `HandlerContext.signal`). For example, with a...

Re-visiting this for https://github.com/connectrpc/connect-es/issues/1253: > My concern is that without a mechanism for detecting doneness in all cases, resource cleanup will be very hard for developers, and they'd have to...

Thanks for the input. I wish there was a variant of AbortSignal that isn't tied to cancellation. We're reverting to include completion in the signal in https://github.com/connectrpc/connect-es/pull/1282. You can still...

> A `field_mask.in` rule with a path of `a` would hypothetically imply that any sub-path also would be valid, such as `a.b` and `a.c`. As written, this limits the field...

The user-agent set by connect-es is important to use because it helps users and us to diagnose issues. Can you provide some details on why it is important to you...