Timo Stamm

Results 302 comments of Timo Stamm

Certainly. But would you want to be stuck with a no longer maintained proto2 down the road? Do you think that switching to getters or immutable is the right call...

@jafaircl, https://github.com/bufbuild/protobuf-es/pull/899 adds the function `createMutableRegistry()`, which creates a registry with a method `add()`. https://github.com/bufbuild/protobuf-es/pull/898 adds a similar function to the [upcoming version 2](https://github.com/bufbuild/protobuf-es/releases/tag/v2.0.0-alpha.1).

Hey Ivan 👋 I think you're correct - a mergePartial that works on the schema information should be much faster than a generic one, like lo-dash. Did you know that...

@ygrandgirard, I'm not sure there's a consensus for how a merge should work. In JavaScript, the very popular [lodash.merge](https://www.npmjs.com/package/lodash.merge) merges array elements, while the equally popular [deepmerge](https://www.npmjs.com/package/deepmerge) appends array elements....

@ygrandgirard, looks like at lease the two of us have consensus 🙂 I think the the upcoming [version 2](https://github.com/bufbuild/protobuf-es/releases/tag/v2.0.0-alpha.1) can mitigate this problem. Instead of adding a method `merge` to...

This feature is implemented in the [upcoming version 2](https://github.com/bufbuild/protobuf-es/releases/tag/v2.0.0-alpha.1) by https://github.com/bufbuild/protobuf-es/pull/866.

See the [documentation for JSON types](https://github.com/bufbuild/protobuf-es/blob/main/MANUAL.md#json-types).

This is implemented in [version 2](https://github.com/bufbuild/protobuf-es/releases/tag/v2.0.0) with the functions `getOption` and `hasOption`. See the [documentation](https://github.com/bufbuild/protobuf-es/blob/main/MANUAL.md#custom-options) for details.

We've looked into making the `typescript` dependency optional, but couldn't find a good way to do that without hurting the experience for users who want to write their own plugin....

Hey Thomas, we've been thinking about a default registry too. In many use cases of Protobuf, there will be a layer on top that makes it easy to pass in...