Timo Stamm
Timo Stamm
Tanner, we'd definitely appreciate a fix, whether it's an improvement specific to connect-es, or a more general one for protobuf-es. One thing to keep in mind is that the current...
Hey @CaptainWang98, here is our [CONTRIBUTING.md](https://github.com/bufbuild/connect-es/blob/main/.github/CONTRIBUTING.md). It has instructions for everything you need to get started 🙂 If you follow the solution described above, you can add tests and run...
@CaptainWang98, defining the function first is a good idea. We are using `type` to declare functions types in this repository. Following this convention, the definition would be: ```ts type ConnectErrorToUniversalResponseFn...
The two complications are eliminated with https://github.com/connectrpc/connect-es/pull/1103 and https://github.com/connectrpc/connect-es/pull/1110. ~There's a (small) new one with https://github.com/connectrpc/connect-es/pull/1079#pullrequestreview-2060075386.~ Fixed by https://github.com/connectrpc/connect-es/pull/1111.
@thesiti92, for the [eliza module](https://buf.build/bufbuild/eliza/docs/main), this path imports the service: ``` @buf/bufbuild_eliza.bufbuild_connect-es/buf/connect/demo/eliza/v1/eliza_connect.js ``` And this path imports the messages: ``` @buf/bufbuild_eliza.bufbuild_es/buf/connect/demo/eliza/v1/eliza_pb.js ``` Are you suggesting that the first path also...
Hey @matt-lewandowski, v0.8.0 is nearly a year old and we've cut a stable v1 since. Would you accept the PR if I update it?
Google protobuf has conformance tests. They are using an executable that runs a test suite against any implementation. It uses a similar pattern to protoc plugins, with a test request...
We agree that this would be nice for type-safety, but it means we have to make properties mandatory in the constructor, something we would prefer to avoid. We haven't found...
> The behavior has changed since this issue was filed. The generated classes for proto2 messages seem to reflect the required/optional fields. See below. @joemckenney, this was actually a bug...
Apologies for the confusion. I've updated the v2 release notes to clarify that it's an _improvement_ over v1. Required scalar and enum fields are no longer optional in generated code,...