Timo Sachsenberg

Results 291 comments of Timo Sachsenberg

Can you check Chris' comments and ask him if there are doubts? If you browse https://github.com/OpenMS/OpenMS/pull/5688/files you should be able to see them in line with the code.

to speed this up @cbielow can you quickly go over your comments and close some that are not so important/style related?

@JeeH-K can you go through https://github.com/OpenMS/OpenMS/pull/5688/files and check the TODOs? Also there is some commented out code/functions that should be removed.

Can we find out what other software is doing here? e.g. is it reasonable to assume that the highest HCD level is used for quant?

this needs more information e.g. when should installer be built and stored as artefacts etc.

Thanks for drafting a big part of the full multi job. How to go forward with the "big problem"? Artifact limits seem to be 500 MB (at most 2000 MB...

I think if we need to keep KNIME we could create temporary folders on our archive (similar as we do for our feature branch builds).

No and I guess you are right. So maybe we can just try with the artefacts (and hope they don't change the billing too soon ;)

That is a good point. I think this can probably be handled by having a dedicated user on our side.

@poshul is this done? can you give an update what is missing if anything?