Timo Sachsenberg

some tests fail https://cdash.openms.de/viewTest.php?onlyfailed&buildid=19323

Thanks! Test pass. I added a few potential reviewers because I think it doesn't hurt to have more eyes on this very central class.

Hi any updates?

I see some code suggestions by chris? accept or decline them to move forward?

Hi. I think we now require newer python / cython versions. Would upgrading to python3.8 or higher be an option for you? We usually don't backport improved python bindings to...

I think he might be referring to https://nightly.link/OpenMS/OpenMS/workflows/pyopenms-wheels/nightly/Windows-wheels.zip%5C?status%5C=completed

related to #5722

not sure... probably nice to have. not high priority though

I think the problem could be that there are no values > 199 at all so LM may move the RT outside the range without getting penalized (error doesn't increase...

Another thing we could look at is using another fitting method: https://github.com/yixuan/LBFGSpp that supports constraining width and rt range