Timo Sachsenberg

Results 291 comments of Timo Sachsenberg

seems to be sufficient to use the new 5.13-ish QtCore and Network version

Ok thanks. Will check where this type comes from and how to change it

ok what about size? this is wrong? https://github.com/OpenMS/OpenMS/blob/develop/src/pyOpenMS/pxds/UniqueIdInterface.pxd#L13

on the left side of the assignment we have a UInt64 https://github.com/OpenMS/OpenMS/blob/develop/src/pyOpenMS/pxds/ConsensusMap.pxd#L28 on the right side a Size type

according to uwe that is a wrapper around Map https://github.com/OpenMS/OpenMS/blob/5c51ad02b833986049f250c1cb46fe02b77b79cc/src/pyOpenMS/addons/ConsensusMap.pyx#L23 but we use std::map can't we then not get rid of https://github.com/OpenMS/OpenMS/blob/5c51ad02b833986049f250c1cb46fe02b77b79cc/src/pyOpenMS/addons/ConsensusMap.pyx#L7-L25

let's see if this works https://github.com/OpenMS/OpenMS/pull/5634

Regarding "Adduct decharging takes too long. Can we improve our default parameters or speed it up." @eeko-kon raised some doubts. Didn't we reduce the huge set of adducts at some...