Tim Johnsen
Tim Johnsen
We are also seeing this happen quite often at Patreon. It's one of our top crashes. I just disabled `shouldRemoveExpiredDataWhenTerminate` to attempt to resolve it.
@CWftw we'll see, the update to Patreon iOS including this change is rolling out now.
I'll try to gather some stats for this today.
Alright, here are some illustrative traces from instruments. I used [this sample project](https://dropbox.com/s/c5vivjd5omkh9ew). ## Traces ||Before|After| |--|--|--| |Image loads not cancelled|[link](https://dropbox.com/s/lkn6es50yv9ot6h)|[link](https://dropbox.com/s/n85yq2kyvwc9p2b)| |Image loads cancelled|[link](https://dropbox.com/s/y5nx8p0m3mhaofe)|[link](https://dropbox.com/s/uf1bpy4zwnph4s2)| ## Screenshots ||Before|After| |--|--|--| |Image loads...
Hm, seems that the encoding may make this challenging. This for example `wikilinks://openarticle?zh-yue/wikipedia.org/%E9%96%8B%E4%BF%A1%E5%88%80` doesn't work at all. `wikilinks://openarticle?zh-yue/wikipedia.org/開信刀` works but throws errors, and decoding that component may make it not...
It looks like Opener ends up opening `apollo://www.reddit.com/r/jailbreak/wiki/faq` as a result of this input, which is what Apollo receives. Perhaps a bug on Apollo's end @christianselig.
Done in https://github.com/timonus/OpenerManifest/commit/b8764b805e0827e28c3914c888763df89f939aae, saved ~100 bytes, could probably use another pass.
Seems like some kind of html redirect is happening that Opener can't follow at the moment. For example: https://u.jd.com/TwbVTdL Redirects to: https://u.jd.com/jda?e=99_2|1_2_2|||&p=JF8BAPEJK1olXDYCVV9cC0oWBm0KGlslGVlaCgFtUQ5SQi0DBUVNGFJeSwJCUx4IUTFUBRpWA1NGBhtDCEoWAmwJGl4XXwcCSwcYVBYZUzpmRQ4ZH19SFwpKTA5LbStKTxgZHFtGFgIJVBhDQHheUld2AnFeHQI-axtyZjpDTjh0QRpANykbci91Wzh-TS99Lk1RCm4-YCtwXRJIHTlXFXVSDggjWwtWQjpoF1clXDYBVV5cDkMQCmsPK2sVXTZJOl9tCXsXBGoBG1kQXwQLV1dbOEsRM184GmsWbQ4KOl0QCCUUbWxFVhYlbQYyV25tC0oWAm84&a=fCg9UgoiAwwHO1BcXkQYFFljcnB1f1JZQFgzVRBSUll%2bAQAPDSwjLw%3d%3d&refer=norefer&d=TwbVTdL Source of page: ``` 京东网上商城 function htmlspecialchars(str){ str...
Yeah, that would probably be sufficient. I need to be able to fire a URL with an app-specific scheme like `gitpoint://` that can open particular GitHub entities.
Excellent, thanks!