Timo Kaufmann
Timo Kaufmann
While working on #116, I noticed that the `sub_sampling` function of `feta_network` is broken. Its not exercised in our standard test-suite, since its only needed when the number of objects...
See https://github.com/kiudee/cs-ranking/pull/118#discussion_r425246426 for details. Should be resolved after merging #118 to avoid conflicts.
Peculiar constant - this should rather be something passed into `__init__` as parameter. But this is something for a separate issue. _Originally posted by @kiudee in https://github.com/kiudee/cs-ranking/pull/157#discussion_r488695680_
## Description This is a work-in-progress of fixing https://github.com/kiudee/cs-ranking/issues/94. See that issue for motivation and context. Currently the one added test is failing since FETADiscreteChoice does not yet conform to...
We have recently added some static analysis and formatting tools. One thing we are not checking for yet is inline documentation. There are some tools out there, for example [pycodestyle](https://books.agiliq.com/projects/essential-python-tools/en/latest/linters.html#pycodestyle)....
`sklearn` issues a warning during the tests: ``` sklearn.exceptions.UndefinedMetricWarning: F-score is ill-defined and being set to 0.0 in samples with no predicted labels. ``` This is because - some of...
We should revert #138 once we have a better fix for #137, such as #115.
A bug like #126 could have been cached by a static check for unused variables. We should think about using (at least some of) `pylint`s checks.
To prevent issues linke #137 we should have a CI check that tries to import `csrank` with only the minimal dependencies.
See https://github.com/kiudee/cs-ranking/pull/129#issuecomment-636857634. We already declare many types in docstrings. Using `mypy` would require us to formalize this a bit more, with the added bonus of static guarantees and better tooling...