Timo Kaufmann

Results 100 comments of Timo Kaufmann

I could imagine something like ``` await has_reviewer_available() ``` where `has_reviewer_available` somehow blocks (or yields the CPU) until the caching mechanism in #71 has found an available reviewer.

Yes, it counts everything that github calls "involves" (authored/left a comment/has an outstanding review request/approved/...). You don't have to be active yourself in the PR either, you just have to...

Right, that is what I mean by active. To be precise, anything github counts as an "update" in the last d days. Activity after merge doesn't count (since otherwise it...

Marvin briefly ignored the rate limit due to a bug. Fix is deployed (#80). Sorry for the inconvenience.

Yes, everybody's limit is exceeded most of the time. @turion you have set it to 3 activities in 7 days, so that can easily be saturated by just day-to-day activity....

Also just to [re-post](https://github.com/timokau/marvin-mk2/issues/86#issuecomment-688514598) it here: Marvin has been on my backburner for a while now, which is why there hasn't been much progress. It has happily chugged along though,...

[Re](https://github.com/timokau/marvin-mk2/pull/92#issuecomment-714367067)-posting a current excerpt of the logs here, which might be interesting: > Oct 22 09:16:28 marvin-mk2: Selecting reviewer from candidates: ['symphorien', 'timokau', 'fgaz', 'glittershark', 'kevincox', 'turion'] > Oct 22...

> Although it also isn't perfect as if I leave a comment and the author doesn't respond for a while then I am probably fine taking another issue. Yes, I...

Yes, I agree that it would be useful. We already use some [teams](https://github.com/orgs/NixOS/teams) for a similar purpose, but pinging one of those always notifies all members. Marvin could have a...

It seems like there might be a misunderstanding, this bot will never merge anything itself. It will only label a PR as needing merge and maybe request a review from...