Timo Hanke
Timo Hanke
https://github.com/dfinity/agent-js/blob/3502217ba8f81595ebd40f468046ba4df83d146c/packages/principal/src/index.ts#L9 Here, the management canister constant is mis-named because it is specified as "Text" not "Hex". The subsequent function `managementCanister()` will fail (bug).
https://github.com/dfinity/motoko-base/blob/8028da2d691151a3202d7539b5828a7a381f40c6/src/Principal.mo#L80 It is a little weird if the base library itself uses deprecated functions because it produces compiler warnings that the user cannot do anything about. Shall we inline the...
The two functions, returning an Iter, would be useful.
The current implementation seems to be creating a lot of individual leafs on the heap that are structurally all the same (`#leaf`). There could be one static `let leaf_ =...
https://github.com/dfinity/motoko-base/blob/5c9145e79bf471fb662b9b4028937783e97e23d1/src/Buffer.mo#L68 As far as I understand the style guidelines this should be `size_` not `_size` because `_size` suppresses a compiler warning.
We need some clarification in the spec regarding which metadata can change over time and which one is guaranteed to be constant. For example, can `decimals` change? It is necessary...
The subcommand `neuron-manage` has an option called `--clear-manage-neuron-followees`. Given that the subcommand is already called neuron-manage that is a repetition. Better names would be `--clear-all-followees` or `-unfollow-all`.
When `--follow-neurons` is the last argument, only followed by `` of the neuron that is being managed, then the command line parser seems to interpret `` as just another followee...
Calling get_full_neuron is not possible with the dfx sign/send combo. That is because the dfx send part will only return a request id and another signed request_status is required. So...
quill signs both the ingress message and the status request. Both have the same expiry. It is possible that the ingress message is submitted before the expiry and successfully processed...