Tim Maffett
Tim Maffett
@tphinney One that thing that would be nice to have acces to, that is not available AFAIK, is the list of all the searchable category tags associated with each icon....
As it exists currently this PR is intended to optimize performance at zero change to the existing validity checks. I agree that wrapping them in an assert like you illustrate...
I have modified this PR to move the argument checking to asserts and add the assert argument checking to all of the web renderers. (Previously the web renderers never checked...
> @timmaffett – we have a bit of distance to go to get this landed...I hope we do...but either way, this effort is AMAZING. Super thoughtful and thorough. "WE" (the...
i had just started reviewing the existing tests for cursors in the engine and will be adding tests for these changes. I am away for the weekend, so it may...
@kevmoo - ok - I will avoid unnecessary syncs. @kevmoo, @dkwingsmt - the tests have finally been added. The test first tests all of the existing functionality (all built in...
I updated the branch like the bot asked. @dkwingsmt @kevmoo Is there a way to get the 'needs tests' tag removed now that tests have been added ? Like I...
@dkwingsmt Just wanted to ping you once again and remind you that the tests have been added and see if we could move forward on this ?
I think if we did make a different entry point the system specific one is the way to do it - BUT on all other platforms `activateSystemCursor` is the way...
@Hixie Yes I would be willing to make any required changes to land this. I created this PR to provided this missing capability for flutter web and would love to...