Tim Maffett

Results 91 comments of Tim Maffett
trafficstars

@domesticmouse You set up the OAuth apps for the GitHub login support right ? I was wondering if for the beta, dev and old channel versions if it was possible...

@jakemac53 - GitHub requires the OAuth endpoints to return to a 'static' url (to which is appends the `gh` and `scope` query parameter string. I am storing current URL state...

@domesticmouse - OK, after digging through the code I realized that the place where we need to fix it is not in the OAuth settings but in the `K_GITHUB_OAUTH_RETURN_TO_APP_URL` google...

Nice! That was fast @domesticmouse ! I have verified that fixes the GitHub logins starting from the non stable channels. (and the updated OAuth application names are nice as well!)...

@domesticmouse - I had created code that does the bounce to dartpad.dev when the url was not dartpad.dev (when a user selects login to github). I can finish testing this...

I have submitted https://github.com/dart-lang/dart-pad/pull/2330 which initiates a bounce if we are not sitting at dartpad.dev when a github login is initiated.

Now that #2227 is now live on dartpad.dev it may be time to consider updating the https://github.com/dart-lang/dart-pad/wiki/Sharing-Guide linked to by the dartpad 'Share' menu item, and additionally extending the 'Share'...

(Although not a complete solution to @Deleplace 's point) #2227 does provide the ability for a user to fork a gist that they are interested in or want to modify,...

@Deleplace I wanted to mention that #2227 is now live on dartpad.dev and if you had a chance to check it out I would appreciated any feedback you might have...

@domesticmouse Well it would depend on how we went about it. If the user was logged into GitHub with their own account it would be trivial to have the share...