Tim Kelty
Tim Kelty
All set, @mtangoo.
> @timkelty the PR is good. Can you add a line in changelog so that we can merge this? Done!
Thanks to everyone for the very useful debugging! @mattgrayisok @i-just I _think_ I got to the bottom of this: https://github.com/craftcms/cms/pull/16464 `craft-asset-storage` is affected because it is [falling back to a...
[craftcms/cms:4.14.0](https://github.com/craftcms/cms/releases/tag/4.14.0) and [craftcms/cms:5.6.0](https://github.com/craftcms/cms/releases/tag/5.6.0) are now released with this fix. Please let me know if anyone else is able to confirm the fix!
Retargeted for 4.13 and ready for review @brandonkelly
@shukitchan @cdloh I had a similar symptom with truncated output when converting from a normal `fetch` to `esi.parse`, although based on your code, it seems like the cause may be...
@cdloh I think I've finally been able to reproduce this! I'm still working on reproducible test, but in this case, it seems to choke if the page has inline SVGs....
After some more testing, it seems likely this may be large single tags, like those found in SVGs or `` tags with large `srcset`s.
@cdloh I was curious, so whipped up an `HTMLRewriter` version: https://github.com/timkelty/esi-html-rewriter This is the test that I think `cloudflare-esi` might choke on: https://github.com/timkelty/esi-html-rewriter/blob/main/tests/long-attributes-and-svg.test.ts
> [@timkelty](https://github.com/timkelty) do you mind if I reuse that test over here? Please do! If you can't reproduce, email me and I can give you the full HTML src that...