Tim Jacomb

Results 1105 comments of Tim Jacomb
trafficstars

/label ready-for-merge ---- This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks!

We have an alternative PR here https://github.com/jenkinsci/jenkins/pull/7017 which fixes both JENKINS-69398 and JENKINS-69214

> > We have an alternative PR here #7017 which fixes both JENKINS-69398 and JENKINS-69214 > > @timja I think #7017 is base on my revise to add some new...

> If we add it to the root directory, can we get a rid of the config in the war directory? Thanks, I meant to do that, fixed in https://github.com/jenkinsci/jenkins/pull/6974/commits/ee970ee9a6773152c2b2a239863d053ce61ba6a9

> All code changed in this PR uses two space indentation, despite files currently (mostly?) being indented with four spaces. This introduces mixed indentation which makes no sense. Can we...

> This looks a lot like both changes should be a single PR, since neither can stand alone without the other? AFAIUI, this one needs the other for indentation to...

I do not plan to squash merge the prettier PR, it has 3 very distinct commits. personally I would prefer to merge this separately, it’s trivial to fix prettier conflicts...

This needs to be fixed in the plugin, its markup is invalid. (in-progress, no promises I'll fix all of it though this plugin is not maintained looking at it's dependency...

**EDIT**: This looks unrelated to guice, I can't get 2.0.1 to work at all **EDIT2**: Needed to implement JobConfiguration in my Configuration How are you guys managing to add the...