Tim Holy

Results 1853 comments of Tim Holy

As I commented there, I don't know the answer. But here's a way of thinking about it: an OffsetArray is really just an optimized representation of an ordered dict, with...

For the record, I think this is a very good change. I am a bit worried about the very point that @johnnychen94 raises. Have you played with it extensively on...

It's basically "sanctioned type piracy." The issue is that Base is incapable of creating arrays with axes that start at anything other than 1. The dispatch hierarchy for Base ensures...

If you can sync this across Base, BlockArrays, and OffsetArrays, by all means go for it! Might want to also check CatIndices.jl as an example of a package that defines...

Base ranges need an overhaul anyway to address https://github.com/JuliaLang/julia/pull/30950. That PR was starting to turn into a nightmare, I think the best option will be to start fresh and go...

> there are many typos with base julia methods and types that fail in Base but don't with OffsetArrays.jl loaded @rafaqz can you give some concrete examples? I'm in agreement...

> from my other issue For posterity: this references #306 OK, but FYI I happened to see this and not that. The more explicit you can be the better: "this...

The me from back then clearly knew what he was talking about. We should listen to him :laughing:

As you can tell from your readings, I'm mixed on this. If I had to take a stance, it would be "against by a hair." Here's why: - `pushfirst!` really...

We can have this if there's enough enthusiasm. I just think that the consensus has never been clear. Lots of people initially think "why isn't that implemented? I'll add it!"...