Tim Fish

Results 467 comments of Tim Fish

I don't know what platform you are on but I couldn't get your ping command to work. When I used the following on macOS: ```ts spawnSync('ping localhost', { shell: true,...

This captures events in CI on all three platforms: https://github.com/getsentry/sentry-electron/pull/1253/files#diff-36e6cd764896407f6f6836936bae915a737ff555a63c8af3a7987ac6f3f06654R24

This `eventLoopBlockIntegration` already uses a worker thread so that it can capture stack traces in any other thread (including the main thread). I will add tests upstream in `@sentry-internal/node-native-stacktrace` to...

I've tested the native module and it captures stack traces from a thread that is blocked indefinitely. What you might be seeing is the fact that once the main thread...

So far only tested this against https://github.com/getsentry/sentry-javascript-node-native-stacktrace/pull/24 and it doesn't get stuck but this could be because of how the locking has been changed. I think we'll get that merged...

It looks like we can detect blocking by cpu intensive synchronous work like in our tests because JavaScript is still executing. With `spawnSync`, it blocks the event loop in a...

If you don't pass a specific `release` to `init` the SDK will default to `appName@appVersion`. We have a test that ensures the correct app version is included when a native...