Tim Fish

I want to retain the v4 tests, duplicate them and test v5 too. To have both versions installed, I was going to use aliases but then realised this does not...

> Movement on the PR looks stalled, but it seems like Express team is looking to emit events that would allow for a simpler implementation. Are you waiting for those...

> [Is that this](https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2437/files#diff-1b58f5156af0284f17ad65321e60b9b6e66243bc656c25d42dc5fba3765560e7R49)? If so, where do I see the assertions for this? [Here are the assertions](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/35247450e3127fd705f09b5f9f578d01f52d63b5/plugins/node/opentelemetry-instrumentation-express/test/v5/express.test.ts#L815-L827) which have been changed to pass. And [here](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/35247450e3127fd705f09b5f9f578d01f52d63b5/plugins/node/opentelemetry-instrumentation-express/test/v5/fixtures/use-express-regex.mjs#L46-L50) is the regex request...

I've improved the code to instrument differently depending on the express version but like for v4, the v5 instrumentation still relies on internals. One option would be to emit tracing...

This can probably just ship as it is and we can migrate to a `diagnostics_channel` solution later. Sentry have already [shipped a version](https://github.com/getsentry/sentry-javascript/pull/15380) of this PR and users are already...

Closing in favour of: - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2801

> Did you forgot to push changes to package.json that included showing running test/v5 tests? Sorry I can't find anything! > The original work is yours, so I'd be happy...

> is there a reason we never merged https://github.com/getsentry/sentry-javascript/pull/12460 Not that I can see other than the conflicts since we bumped the minimum Deno version to v2

> Without .clear there, the breadcrumbs have older logs too Ah, I think we might also need to fix this before the isolation will work: - #15455 I don't want...

> Did you mean Deno? Yes, sorry. I'm thinking about lots of different problems at once and confusing myself!