Ümit Seren

I really think that one has to first learn Redux and all the concepts around it. I highly recommend to watch Dan's Redux Videos (Dan is the creator of Redux)...

@petemounce How about making it configurable ? By default the endpoint only returns metrics with the `type` label but the user can maybe configure what additional labels to return by...

@petemounce : Sorry for the lack of feedback. I think that sounds like a plan.

@harre-orz Looks good. I would have 2 suggestions: 1. Add the unit to the `goss_duration` metric (i.e. `goss_duration_seconds`) according to the best practices of [Prometheus metric naming](https://prometheus.io/docs/practices/naming/) 2. Maybe add...

@harre-orz : You might be right regarding the summary statistics. I am just wondering if the other output formats (json, etc) output those summary statistics as well and if it...

@aelsabbahy : I skimmed through the code and from my point if view it looks good. The change is relatively small and the added labels would help us a lot...

@petemounce: Thanks for the detailed comparison. @aelsabbahy: Based on the above table and comparison I would also prefer #607 especially because it avoids missing metrics because I have run into...

@petemounce: One difference I noticed between your PR and this one is that this one additonally adds the `Property` and `ResourceId` as a label to the metrics. I remember we...