Matt Wilson comments

Results 6 comments of


                                            Matt Wilson

Reference to PeterO.Cbor version which contains a public advisory

I just noticed that dependabot automatically submitted a PR for the fix, https://github.com/MichaelGrafnetter/DSInternals/pull/138 for reference.

Fix for issue where plugins that reference types from other assemblies cause Pipeline to display the "Invalid / Missing importer" error

EDIT: Apologies, I realized that the issue in 6538 was not the same because the outright crash was a result of testing. The exception in this case is swallowed higher...

Fix for issue where plugins that reference types from other assemblies cause Pipeline to display the "Invalid / Missing importer" error

Is there a way I can send you the bits? You'd need my assemblies too. Alternatively, I can invite you to my VSTS repo and you can build it directly....

Fix for issue where plugins that reference types from other assemblies cause Pipeline to display the "Invalid / Missing importer" error

Sorry for the iteration spam, but I reworked the resolver to fit into the pattern you already had better and fix an issue I encountered while testing.

Fix for issue where plugins that reference types from other assemblies cause Pipeline to display the "Invalid / Missing importer" error

Yes, that's correct. The issue I encountered that warranted the further updates was that the N level deep references cause the same issue. The latest iteration caches the requesting assembly...

Fix for issue where plugins that reference types from other assemblies cause Pipeline to display the "Invalid / Missing importer" error

I thought about that, but there's extra complexity reloading the other types you need, not just the plugins. I thought caching the dll locations would be a reasonable middle ground.