Tim Dorr

Results 176 comments of Tim Dorr

Moved this over to https://github.com/ReactTraining/history, as that's where these APIs originate.

This is because we coerce the INIT and REPLACE actions to your Action type: https://github.com/reduxjs/redux/blob/25f8a6c92773967d20641c6c239f31c1b01dd459/src/createStore.ts#L340 https://github.com/reduxjs/redux/blob/25f8a6c92773967d20641c6c239f31c1b01dd459/src/createStore.ts#L286 Perhaps we can make something like `reducer(state: State, action: ReduxActions) => State` that will...

So, we basically lie and say [these special actions with randomly-generated `type`s](https://github.com/reduxjs/redux/blob/26f216e066a2a679d3cae4fb1a5c4e5d15e9fac6/src/utils/actionTypes.ts#L15-L19) are actually set with the `type`s you define. Your own Action type (which [extends our `Action` type](https://github.com/reduxjs/redux/blob/26f216e066a2a679d3cae4fb1a5c4e5d15e9fac6/src/types/reducers.ts#L29)) is...

I don't think you were totally wrong, but I think _I_ was wrong about having a separate ReduxAction. We should keep our types as similar as possible. [Here's a better...

I dunno if @cellog is around, but if he is, did he want to take a look at this?

Just to chime in here: I'm cool with changing the signature of the API, given that this will release in a major. However, now that I think about it in...

ESM support is coming, but is only in the experimental builds at the moment: https://www.typescriptlang.org/docs/handbook/esm-node.html

We can just do it now and see if there's any notable impact. If it doesn't actually do anything to the bundle (and I suspect it may not), it probably...

This is impressively causing Node to segfault, so is there some looping going on in the tests? That's usually the cause of those kinds of hard crashes. @markerikson Did you...