Tim Deschryver comments

Results 249 comments of


                                            Tim Deschryver

getByRole not finding Element by implicit role

This should be available in the next version of `aria-query`. The fix was committed in this PR https://github.com/A11yance/aria-query/pull/447 (updated the relatedConcepts of the button role)

Pass the argument index to the comparator function

Could you elaborate/give an example why the index is needed?

@ngrx/data: Track only changes, then save. Flush Action ?

Hi thanks for opening this issue. I do like the idea, but I don't think that we want to make big changes to `@ngrx/data`.

Embedded app multiple times into 3rd party website - stores influencing each other

AFAIK that shouldn't happen. It's hard to investigate because we don't see the NgRx store implementation. It will be easier to investigate if you can create a minimal reproduction.

Using a custom generic function for defining props in createActionGroup results in weird TypeScript errors

I think this is related to https://github.com/microsoft/TypeScript/issues/241, we've experienced a similar behavior with the `on` functions within `createReducer`.

eslint plugin should use correct version of 'concatLatestFrom' in autofix for rule 'prefer-concat-latest-from'

Just for a sanity check, updating the import reference from `effects` to `operators` won't break a project if it uses the fix feature, right? Because `operators` is a dependency from...

eslint plugin should use correct version of 'concatLatestFrom' in autofix for rule 'prefer-concat-latest-from'

> Just for a sanity check, updating the import reference from `effects` to `operators` won't break a project if it uses the fix feature, right? Because `operators` is a dependency...

Return type of selectQueryParam is incorrect

Hi, it seems like you're right! Do you want to create a PR for this? We can schedule this for v18 version and document this as a breaking change.

updater-explicit-return-type No longer needed with NoInfer

This will be something to test if `NoInfer` does fix this issue. If it does we can indeed remove the two (I think) rules.

Implementing OnInitEffects with functionalEffects

This isn't supported. What's the use case that you have on your mind that does need this feature?