Tim Arney

Results 39 comments of Tim Arney

I always thought it only got the name and version from the .php file but maybe not https://www.cozmoslabs.com/1667-wordpress-automatic-updates-based-on-folder-name-is-that-a-problem Also found this with a little more detail https://wordpress.stackexchange.com/questions/56968/if-i-rename-a-plugin-in-its-main-php-file-do-i-still-get-update-notifications ``` The API...

> Should I remove references to improvedAutosaves, considering https://github.com/GoogleForCreators/web-stories-wp/pull/12357. CC @timarney Re-tested my other PR further last night --- seems to be working as expected.

@spacedmonkey @swissspidy --- adding this as ready for review now to get some feedback --- still testing on my end. 1) I think the UI (to let the user know...

https://github.com/GoogleForCreators/web-stories-wp/pull/12335#issuecomment-1254836974 > Screen.Recording.2022-09-22.at.11.25.31.mov > In my testing, I found two things. > > * It seems like some of the segments are 19 / 21 seconds. This seems odd, worth...

RE: https://github.com/GoogleForCreators/web-stories-wp/pull/12335#issuecomment-1254883207 > After thinking a bit more about it, I am definitely not a fan. Let's force the segments to be accurate. Added force key frames , segment times...

@swissspidy --- Thoughts on best way to get the batchId back to videoSegment ... to check using the useEffect ?

> I am seeing this work with a 7 minute video. But after the videos are done processing, it then pages are not created. Any idea why this is happening?...

@swissspidy --- taking another look / testing this. We now end up with a blank page at the start --- is this what we want? The previous code created new...

> What could you miss in less than a second? A video of less than a second is not useful to a user. Maybe the cut off should be at...

> I am still not seeing the pages create at all. Not seeing any errors. Re-tested with a few different videos 4-5 times worked ... the other time I didn't...