Tim Arney

Results 39 comments of Tim Arney

@swissspidy I added a [trackError](https://github.com/GoogleForCreators/web-stories-wp/pull/12091/commits/866d23b8c47b510f5bac28f758ae498b8784e4a9#diff-362408cc6041a2dba24390bc644b5653d35faa4539ea86ef2bbe33221797b9c0R103) to help surface anything that might come up in the future.

> Looks like some tests are failing now. Haven't checked closely, perhaps they need updating. ``` expected document not to contain element, found Media Upload Button! instead 172 | const...

Tested with a user who doesn't have upload permissions --- ===== I believe this is what we're expecting --- no upload button but can still hotlink.

Erroring on the `MediaInput` / ForwardRef > Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to...

https://github.com/GoogleForCreators/web-stories-wp/pull/12021#discussion_r937569971 > Not sure if you discussed this somewhere else that the comment was marked resolved, but since now enablePosterHotlinking is always true, wouldn't we always display this and can...

> Hm, okay. I suppose we can leave as is then. Just by reading the code I assumed that the whole component could always displayed but canUpload should only be...

@swissspidy any idea why removing that causes issues with the MediaInput (at least in the tests). ```javascript detail: Error: Element type is invalid: expected a string (for built-in components) or...

> Pascal to take a closer look into this to see what kind of options we have here. @swissspidy are you still going to [look at options](https://github.com/GoogleForCreators/web-stories-wp/pull/11941#issuecomment-1192331381) for this one?

Looks like the error message is Which traced back is because of an empty array getOriginalSize( ``` originalWidth: mediaUrls[0].width, originalHeight: mediaUrls[0].height, ```

Seems the only way I can re-create now is - "fresh load of the page" - visit tab - scroll to down --- at some point the error happens ---...