Tim Abell

Results 106 comments of Tim Abell

I've started a maintenance branch for v1 (called v1), and master is now for the v2 release.

I've created a temporary branch while I look closer at the code you've provided and try it out on my machine. https://github.com/timabell/ef-enum-to-lookup/tree/description-column - this fixes the whitespace issues.

So having had a closer look at the overall change I like it, and thanks for your work on this. Mostly my feedback is just trivia. There's one bigger thing...

I've had a read about it and that looks like a good choice to me.

I'm out of time/energy for the moment. It'd definitely be good to get this cleaned up and merged in. Todo: - switch to displayattribute - make sure both display and...

my description-column branch has been squashed & rebased onto the latest master, still more to do on it but that's now the best place to start

Thanks @sveinhelge At a glance it looks promising, couple of bits of feedback: - How about `EnumDisplayName` instead of `EnumNameValue` - The lack of indentation in the generated sql is...

Would you be able to write a unit test & fix? Then do a PR? Or if not I could do it on a consultancy basis. Is it causing you...

I assume that would have to work with EF core, which I'm guessing would require a fair bit of work.