Tim Abbott comments

Results 1421 comments of


                                            Tim Abbott

Auto-reload behavior when connected to an invalid organization is buggy

That reproduction attempt doesn't look right -- you need to connect to multiple organizations successfully (say chat.zulip.org and your development server), and then shut down your development server and try...

Auto-reload behavior when connected to an invalid organization is buggy

Closing as we suspect we fixed this annoying symptom long ago.

CSS selector performance: Use classnames instead of div.

> At both of these places, using the div selector feels like the right thing to do since it is applying generic rules to divs. For the second case of...

CSS selector performance: Use classnames instead of div.

> I've used before and after screenshots for most of the commits to check for any regressions myself. I think it would take some time to put all those together...

CSS selector performance: Use classnames instead of div.

Merged, after updating the relevant commit message to note the investigation in https://github.com/zulip/zulip/pull/31204#discussion_r1716315978. Thanks @shubham-padia!

CSS selector performance: Use classnames instead of div.

This was backported in #31476.

Fix new messages marked read on active window.

The review comments above don't change the algorithm, so I think the next focus will be on testing.

Fix new messages marked read on active window.

This looks good, merged, thanks @amanagr! Think this is low enough risk that we can merge to `main` already.

More tweaks to slack import process.

Merged, thanks @amanagr!

Notify user when messages in unsubscribed streams are not marked as unread #23470

Posted a couple comments on the UI code. The backend can be merged as soon as we get approval from https://chat.zulip.org/#narrow/channel/378-api-design/topic/unreads.20in.20unsubscribed.20streams/near/2009252; feel free to DM me if you see consensus...