Tim Schilling

Results 420 comments of Tim Schilling

I'd like to encourage you to make the changes to the docs that cover the scenario(s) you encountered, then open a PR.

That's fair. The `OAuth2CallbackView` could be extended to expose the three error cases as separate methods so that they can be overrided more easily. Would that be something you're interested...

Sounds like this check was due to this change in psutil? https://github.com/giampaolo/psutil/issues/2396 Makes sense. Glad to see this moving forward!

Thank you for opening an issue, would you be able to create a PR to fix this?

Have you taken a look at the JWT without verifying the signature to confirm it looks correct? You can do so by disabling the `verify_` aspects here: https://github.com/snok/django-auth-adfs/blob/378f14129d774ac035804e09f7b6a1b3f5a3f71f/django_auth_adfs/backend.py#L128 There may...

I'm curious why specifying the redirect via `state` doesn't work as a workaround?

I think using Django's `ALLOWED_HOSTS` setting would be reasonable. It feels overly redundant to create a separate setting. I would be open to creating a `get_*` method on the view...

I was imagining this being useful for a services based approach where you authenticate against `login.domain.com` and then are redirected to `app.domain.com`. I'm not sure about the security implications of...