django-auth-adfs icon indicating copy to clipboard operation
django-auth-adfs copied to clipboard

Unable to view Email ID in Login Failed Page

Open ImamAbdullahKhan opened this issue 1 year ago • 1 comments

As per the documentation we can use custom login page when in settings CUSTOM_FAILED_RESPONSE_VIEW calls a function like AUTH_ADFS = { 'CUSTOM_FAILED_RESPONSE_VIEW' : 'app1.views.login_failed' } and the login_failed function takes 2 arguments: request, error_message and status.

Now if I want to display for which email login is failed or user is not already registered in django app, I have request arguement only that may contain the login email, but unfortunately it doesn't have any object which stores the login email, which I think should be present so that on so that it can be used to display in the login_failed page.

ImamAbdullahKhan avatar Mar 28 '25 14:03 ImamAbdullahKhan

That's fair. The OAuth2CallbackView could be extended to expose the three error cases as separate methods so that they can be overrided more easily. Would that be something you're interested in implementing?

tim-schilling avatar Mar 30 '25 14:03 tim-schilling