Tilman Schweitzer

Results 10 comments of Tilman Schweitzer

I think this issue can be fixed by limiting the concurrency. If a limitation is necessary seems to depend on the content (depth, collection size etc). I'll open a PR...

I have the same issue and I can verify that the fix in the open pull request fixes my issue. Would be great to see that fix in an upcoming...

@Gillespie59 Actually I think that could be possible. I remember that I had to distinguish between parameters and global variables for another rule. BUT I don't think that it is...

I think a custom method $scope.myCustomMethod must be initialized on some parent scope and than your independent controller depends on code from a higher scope. Therefore I'm not sure if...

Good idea. As they are not using ESLint so far, we should check there contribution guidelines carefully to not run into some bureaucratic problems ;-) I could do that or...

Nice idea. Your can already achieve a function param limit with the built-in ESLint rule max-params (http://eslint.org/docs/rules/max-params), but a custom rule for angular would be nice too.

Ok, no I understand your use-case. Actually I had the same problem and the max-params were way to high for normal function.

Good point. I also think the rule `no-run-logic` is not exactly what the referenced rule by johnpapa says (https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#style-y171).

@nonoumasy A max concurrency of 45 worked for my use case. Around a concurrency of 48 the issue started again. But I don't know if there are other aspects that...