Till Speicher

Results 5 comments of Till Speicher

[Feature request] Allow for composite primary keys, including foreign key columns as part of the PK

Thanks for being interested in supporting this! Defining PKs and composite foreign keys in the Meta class makes sense. I can try implementing this as a PR, but before getting...

[Feature request] Allow for composite primary keys, including foreign key columns as part of the PK

Thank you for the detailed reply! All the points you raised make sense to me, i.e. only allowing either a `PrimaryKeyConstraint` or `primary_key=True`, the `ForeignKeyConstraint` interface you suggested and using...

[Feature request] Allow for composite primary keys, including foreign key columns as part of the PK

Ok, again that makes sense. The only thing to consider wrt. accessing and setting the FK columns are overlapping FKs. What I mean is this: ```python class A(ormar.Model): class Meta:...

[Feature request] Allow for composite primary keys, including foreign key columns as part of the PK

Wrt. allowing access to the underlying FK columns, what I thought of was to disallow direct column access and only allow setting these columns via the FK constraint's name. I.e....

[Feature request] Allow for composite primary keys, including foreign key columns as part of the PK

These points make sense to me! I tried to cover all the points we discussed so far through tests and started PR #138 to get going with the implementation. So...