tigris icon indicating copy to clipboard operation
tigris copied to clipboard

feat: Support filtering on array of objects or array of primitive types

Open himank opened this issue 2 years ago • 1 comments

This allows to perform filtering on:

  • An array of objects
  • An object that has an array of objects
  • Primitive Arrays

Syntax to query remains the same,

  • For nested Array Objects: {"filter":{"obj.arr_obj.field":"foo"}}
  • For primitive arrays: {"filter":{"arr_field":"foo"}}

himank avatar Oct 19 '22 09:10 himank

Codecov Report

Base: 31.79% // Head: 32.17% // Increases project coverage by +0.37% :tada:

Coverage data is based on head (f19379d) compared to base (254ec91). Patch coverage: 66.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   31.79%   32.17%   +0.37%     
==========================================
  Files          96       96              
  Lines       11276    11429     +153     
==========================================
+ Hits         3585     3677      +92     
- Misses       7369     7414      +45     
- Partials      322      338      +16     
Impacted Files Coverage Δ
server/services/v1/api.go 0.00% <0.00%> (ø)
query/filter/filter.go 54.01% <41.66%> (-1.30%) :arrow_down:
server/services/v1/search_indexer.go 50.71% <57.14%> (+2.21%) :arrow_up:
schema/schema.go 69.04% <63.15%> (+0.21%) :arrow_up:
schema/fields.go 78.47% <79.16%> (-2.11%) :arrow_down:
schema/collection.go 70.49% <90.00%> (+1.21%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 19 '22 11:10 codecov-commenter

I am planning to first release it for an Array of primitive types and then later for an Array of objects as this needs a lot of changes. Closing this PR for this https://github.com/tigrisdata/tigris/pull/607

himank avatar Oct 20 '22 15:10 himank