Joe Farro

Results 19 comments of Joe Farro

An updated sample: http://jsfiddle.net/8WqxC/2/ On this data: ``` javascript var playlists = { "Favourite Songs": { "2014": ['song a', 'song b'], "2013": ['song c', 'song d', 'song e'] }, "Favourite...

I think a prop like `dismissOnClick` would open the door to having interactive content in the notification and would therefore be super useful. As an example: ![exception-notification](https://cloud.githubusercontent.com/assets/2304337/23827533/e5b72d18-0683-11e7-8a51-695a5f152078.png) Come to think...

It's a really interesting idea to have more expressive heuristics around span coloring. I've always thought using service name or anything with similar cardinality is a losing battle. Great point...

Now that I've re-read this, I can see the PR is also proposing changes to various aggregations, like the service tags in the search results. That makes sense in that...

@pavolloffay, thanks for creating this ticket. The current search implementation has some severe issues, returning full traces being one of the issues, along with - [#892 - Search returns results...

@rneha725 Fantastic! Please do. Contributions are definitely welcomed! We've been thinking it would be great to refine this aspect of the UI. To that end, I was brainstorming a bit...

@yurishkuro, @pavolloffay The comparison doesn't consider process tags. The reason the two `reviews.bookinfo` nodes are not grouped is because one is a leaf while the other is not. The span's...

@objectiser thanks for reporting this. The spans for `istio-mixer.v1.Mixer/Check` are not combined because they are not both leaves or both parents; leafs and parents are not combined. The current treatment...

@objectiser Thanks for the feedback. I wanted to add two more grouping approaches that recently came up: - Group on service-operation, i.e. for any service-operation in one of the traces,...

I want to note @yurishkuro's suggestion of showing the options as a series of checkboxes. Enabling a lower-checkbox would automatically enable any checkboxes above. I.E. you cannot have only the...