CalibrationTools icon indicating copy to clipboard operation
CalibrationTools copied to clipboard

extrinsic_calibration_manager can‘t find!

Open 0116lhc opened this issue 1 year ago • 5 comments

The package extrinsic_calibration_manager cannot be found in the sensor folder. I've pulled the code several times but it's still missing. Could you please confirm the location of this package?

0116lhc avatar Apr 24 '24 14:04 0116lhc

Hi, that is because the extrinsic calibration manager is no longer. Now we have a different one called sensor calibration manager, but the documentation is currently being written in https://github.com/tier4/CalibrationTools/pull/164

knzo25 avatar Apr 24 '24 14:04 knzo25

Hello Kenzo,

Can I follow the current documentation for manual calibration and change the steps regarding the extrinsic_calibration_manager directory for the sensor_calibration_manager directory?

yoepav avatar May 24 '24 13:05 yoepav

Hi, Thank you for using our tools. Sadly, I am not the maintainer of the manual calibration tool, so its use under the new scheme will need to wait until the maintainer ports the tool to the new API (or, if you prefer, you could use a previous version of the repository that is compatible with the manual tool)

knzo25 avatar May 24 '24 13:05 knzo25

Hi Kenzo,

I tried using the main branch instead of the tier4/universe branch but sadly that doesn't work. So I guess I'll have to wait for the port. Thank you very much anyway.

yoepav avatar May 28 '24 11:05 yoepav

Hi @yoepav & @0116lhc,

The latest Autoware.Universe repo had some package renaming, which causes the rosdep dependency issues you've listed.

I've forked the CalibrationTools repo with the correct dependency package naming and no longer experience the dependency issues. My fork also reverted to the older version CalibrationTools (i.e. with extrinsic_calibration_manager and aip_x1 directory). I hope this can be useful untill the re-written calibration docs are ready.

dtonda8 avatar Jul 07 '24 03:07 dtonda8

Hi @yoepav & @0116lhc,

The latest Autoware.Universe repo had some package renaming, which causes the rosdep dependency issues you've listed.

I've forked the CalibrationTools repo with the correct dependency package naming and no longer experience the dependency issues. My fork also reverted to the older version CalibrationTools (i.e. with extrinsic_calibration_manager and aip_x1 directory). I hope this can be useful untill the re-written calibration docs are ready.

Hello dtonda, thanks for the upload, I have tried your version of the calibration tools but fails to colcon build. Screenshot from 2024-08-15 14-01-22 Do you know what might be the reason for this?

TimDing-aoi avatar Aug 15 '24 21:08 TimDing-aoi

Hi @TimDing-aoi, I've created a new issue for this in my fork (it's most likely due to Calibration repos referring to incorrect package naming). If you find out where exactly the issue lies and resolve it, you can create a pr. I will also look into this when I am free.

Edit: rosdep issues resolved, colcon build should work

dtonda8 avatar Aug 15 '24 21:08 dtonda8

@dtonda8 I am pretty sure the code in this PR works https://github.com/tier4/CalibrationTools/pull/164

knzo25 avatar Aug 19 '24 20:08 knzo25

Yes, that pr seems to work. The only issue is that you'll need to switch to a slightly older version of autoware.universe, otherwise the output of rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO is this: Pasted image 20240820075540

Autoware.universe recently renamed kalman_filter to autoware_kalman_filter in this commit So we should git checkout to a commit before that (fd09a5b) Pasted image 20240820080520

dtonda8 avatar Aug 19 '24 22:08 dtonda8

@dtonda8 I just updated the PR branch to be compatible with the latest universe (https://github.com/tier4/CalibrationTools/pull/164/commits/1dfc8d72728fb32867fb88af8ee954d6aae62c34)

knzo25 avatar Aug 20 '24 05:08 knzo25

@knzo25 Legend! Thanks for doing that. To everyone else looking for a CalibrationTools version compatible with the latest Autoware and matches the current extrinsic_calibration_manager docs, please use knzo25's pr branch.

dtonda8 avatar Aug 20 '24 05:08 dtonda8

These issues should disappear in the main branch now https://github.com/tier4/CalibrationTools/pull/164

knzo25 avatar Sep 24 '24 22:09 knzo25