CalibrationTools icon indicating copy to clipboard operation
CalibrationTools copied to clipboard

feat(ceres_intrinsic_camera_calibrator): ceres-based intrinsic calibrator

Open knzo25 opened this issue 1 year ago • 1 comments

Implemented a ceres-based camera intrinsics calibrator. Numerical results seem to be the same as opencv but it is way faster when using a large number of calibration images

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • [ ] The PR follows the pull request guidelines.
  • [ ] The PR has been properly tested.
  • [ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [ ] There are no open discussions or they are tracked via tickets.
  • [ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 avatar Nov 01 '23 07:11 knzo25

Codecov Report

Attention: 338 lines in your changes are missing coverage. Please review.

Comparison is base (b0153ee) 0.95% compared to head (a0edbff) 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##           tier4/universe    #141      +/-   ##
=================================================
- Coverage            0.95%   0.00%   -0.96%     
=================================================
  Files                 269       4     -265     
  Lines               20908     338   -20570     
  Branches              387       0     -387     
=================================================
- Hits                  200       0     -200     
+ Misses              20551     338   -20213     
+ Partials              157       0     -157     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rinsic_camera_calibrator/reprojection_residual.hpp 0.00% <0.00%> (ø)
...rator/src/ceres_intrinsic_camera_calibrator_py.cpp 0.00% <0.00%> (ø)
...tor/ceres_intrinsic_camera_calibrator/src/main.cpp 0.00% <0.00%> (ø)
...librator/src/ceres_camera_intrinsics_optimizer.cpp 0.00% <0.00%> (ø)

... and 269 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 01 '23 08:11 codecov-commenter