Tien Vo Xuan

Results 13 comments of Tien Vo Xuan

Are these what you are looking for? * https://github.com/pact-foundation/pact-php/pull/210/files#diff-a334808eb96ed5d596df9e23b18cee93f72bd6027af7a02df9f840204b4ee4cbR21 * https://github.com/pact-foundation/pact-php/pull/210/files#diff-a334808eb96ed5d596df9e23b18cee93f72bd6027af7a02df9f840204b4ee4cbR41 Note: this pull request is **not** reviewed and merge yet.

> And do you still using `MockServerEnvConfig`? Yes, I am trying to make the PR small and easy to migrate to new version as possible. But I removed almost half...

Something wrong with the CI: * It should only run on `7.4` and `8.0`, but it also run on `7.3` * Linter is warning about code on `master`, not code...

Still problems in my comment above. I think CI is cached so it always run against `master` branch. I don't know how to fix from my side. Github Actions in...

@cfmack I fixed the conflict, please take a look again

Your merge commit has syntax error ce65785. I re-based and forced push anyway. New code support specification v4.0 . Tests will not be passed until version 0.1.3 of FFI library...

Updated Pact FFI library to 0.1.3 . Tests will be passed when approve.

@cfmack In case you haven't seen this comment on Slack yet https://pact-foundation.slack.com/archives/C9W94PXPY/p1646321219144749

My solution for Symfony 3.4 and 4.4 is creating custom recipes for them: ``` # ORM export SYMFONY_ENDPOINT=https://flex.symfony.com/r/github.com/symfony/recipes-contrib/832 composer require tienvx/fos-oauth-server-bundle-orm # ODM export SYMFONY_ENDPOINT=https://flex.symfony.com/r/github.com/symfony/recipes-contrib/833 composer remove tienvx/fos-oauth-server-bundle-mongodb ``` These...

Thanks @odoucet I rebased your patch on Api Platform Core 3.1 and it work fine for me. Here is the link to the patch in case someone need it https://gist.github.com/tienvx/251bb458165e8442b7dd5fd58ce50bd9...