Tienifr comments

Results 171 comments of


                                            Tienifr

[$250] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

# Update Proposal @parasharrajat I updated my solution in here: https://github.com/tienifr/App/pull/18. Pls help to check, thanks.

[$250] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

@conorpendergrast Thanks for your review. I realized that new URL not work on native, so I changed to use url libs. Pls help check: https://github.com/tienifr/App/pull/18

[$250] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

@parasharrajat I've updated my PR to use regExp: https://github.com/tienifr/App/pull/18. Pls help check again. Thanks Here is the sample result of `getLocation` function:

[$250] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

@parasharrajat Thanks for your review. I've updated my sample PR: https://github.com/tienifr/App/pull/18

[$250] Bug: old message not loading while switching from offline to online reported by @gadhiyamanan

# Proposal ## Problem - Currently, in https://github.com/Expensify/App/blob/7044ab2b96067081c8f67191e51fa859dba66d91/src/pages/home/report/ReportActionsView.js#L263 when user scroll to get old message, in function `loadMoreChats`, `ReadOldestAction` will be called and update `isLoadingMoreReportActions=true`. After that when API is...

[$250] Bug: old message not loading while switching from offline to online reported by @gadhiyamanan

@thienlnam In [here](https://github.com/Expensify/App/blob/e38df100d62d197689bb16888a3ac7859f157681/src/pages/home/report/ReportActionsView.js#L163-L175), `isLoadingReportActions` will be updated but `isLoadingMoreReportActions` is not updated in `Report.openReport` and `Report.reconnect` https://github.com/Expensify/App/blob/e38df100d62d197689bb16888a3ac7859f157681/src/libs/actions/Report.js#L695-L725 https://github.com/Expensify/App/blob/e38df100d62d197689bb16888a3ac7859f157681/src/libs/actions/Report.js#L732-L758 ## Solution 2 If you want to update `isLoadingMoreReportActions` in https://github.com/Expensify/App/blob/e38df100d62d197689bb16888a3ac7859f157681/src/pages/home/report/ReportActionsView.js#L163-L175, we...