Tiến Nguyễn Khắc
Tiến Nguyễn Khắc
Hey guys, would love to get this working in an environment outside of Node.js. I think this would boost adoption greatly, as a lot of serverless runtimes (i.e. Cloudflare Worker,...
@kenhuuu thanks for getting back & reminding me about the integration test, I was able to run it locally and have all tests passed. For actually running in a browser...
Have also just tested & fix bugs when running this in an actual browser. Everything seems okay so far.
Forgot that `globalThis.crypto` is not available on Node 18, only 19+ (hence the failing test on CI), so I have made a change to use [uuid](https://github.com/uuidjs/uuid) instead. But optionally we...
Hmm, looks like the `.nvmrc` file was picked up by the license checker. `.nvmrc` files can't contain comment, so I have added it to the list of ignored files.
@kenhuuu Regarding the Node version, whatever make sense to you guys, of course. It's not a major deal. But I think the wording in the link that you shared could...
@kmcginnes Thanks for taking a look at this, regarding testing in a browser env, yes that would potentially be a much bigger change than this PR 😅, so I think...
@kenhuuu Node 18 is compatible with all ES2022 features, so the changes to ESLint should be good. Regarding the Node version, I'm okay with keeping it 18 now. Since it...
@vkagamlyk the proper way would be to actually run the unit tests in the browser, like @kmcginnes mentioned. But that could potentially be a huge change to the current test...
@vkagamlyk also, because the API signature is the exact same, those existing examples can be run just fine in a browser environment.