Tiến Nguyễn Khắc
Tiến Nguyễn Khắc
Update: I was able to write a test to consistently trigger the error n prove that my change should work.
Have made a change to only re/initialize on interruption.
Oops, forgot to enable my test since it works now, have done so.
@li-boxuan @porunov all tests passed, can you guys take a look 👀? Keen to get this merged soon 💪.
> I am sorry but I seem to have missed some context. Do you know why @mad 's previous PR didn't pass the test, and what did you do differently...
Thank you @mad, I have committed the suggested changes.
> Thanks for your contribution! > > For proper testing, you need to disable test filtering [here](https://github.com/JanusGraph/janusgraph/pull/3990/files#diff-45fa57a74f390fd8df1d26b15b09bfae64ecae79bce96baf1b74b0304d366af2L25), [here](https://github.com/JanusGraph/janusgraph/pull/3990/files#diff-54e3bb714ade38aba4e19d5db5350902e8b6ddc058e0e1a0361c03fb331144ebL25) and [here](https://github.com/JanusGraph/janusgraph/pull/3990/files#diff-74e5efef2770d32a4554dcea2a6f0644bee1640216b192a8ea7d24756c154a65L25) > > To be completely correct, you still need to...
@mad @li-boxuan I have implemented the interruption retry logic.
tp-test are failing, is there anyway I can run n debug these locally?
I've integrated some of the other changes from @mad, so the interruption test suite should pass now. cc @mad @li-boxuan