Tiến Nguyễn Khắc
Tiến Nguyễn Khắc
> The requirement is not one "active" subscription. It's just one subscription without unsubscribing for the normal use case. Hmm 🤔, alright, I'll have a go at keeping that same...
> btw, I'm aware that the current implementation is a hack and not ideal. I'm not very happy with it. So, suggestions are very welcome. Honestly, I would like to...
@dai-shi okay, I was able to figure out a way to remove that 1 additional subscription. #2225 will also still be fixed by this.
@dai-shi Okay that make sense, thanks for the explanation.
@dai-shi let me know if these changes are all good now btw 🙏
@dai-shi > Can you briefly explain why/how it's possible? I just start over again with the goal of adding as little moving parts as possible, tested against #2225 and it...
> But, it feels you include both the refactor and the fix. I have no idea what was the actual fix tbh :)) Just testing out random stuffs until it...
> > Just testing out random stuffs until it works. > > I hope you can spot the exact change that fixes the behavior. It would be really nice if...
Hey @dai-shi sorry I wasn't keeping up to date with this PR 😢 Had a look again today, I wasn't able to reproduce this error in a unit test, but...
Yeah, you are right. I'll close this PR for now until I can find a way to write a unit test for this :(