Michał Pierzchała comments

Results 285 comments of


                                            Michał Pierzchała

trafficstars

List Available Apple Devices

Sounds like something useful, happy to review PR :)

List Available Apple Devices

Doctor command has some, you can check that

fix: update logic to check for available ios devices for `log-ios` to work

It looks like we have some overlapping implementations, and this is properly resolved in run-ios, but it haven't propagated to log-ios: https://github.com/react-native-community/cli/blob/b3812eac55dd979bb82b078f347fd45f69dc4392/packages/cli-platform-ios/src/commands/runIOS/findMatchingSimulator.ts#L70-L73 Would you be so kind and refactor this...

feat: add VSCode Insiders support

I can't find settings to enable/disable draft PRs. Maybe GH is changing something? We didn't disable it explicitly as far as I know.

Change default location of iOS and Android folder

Oh we should fix that. Would you like to contribute @jenshandersson? cc @grabbou

Change default location of iOS and Android folder

@hamidhadi make sure you're on the [latest version of the `@react-native-community/cli`](https://github.com/react-native-community/cli#updating-the-cli).

Why remove Android custom root?

Anything preventing you to use `project.android.sourceDir` as documented here: https://github.com/react-native-community/cli/blob/main/docs/projects.md in your react-native.config.js?

Cannot invoke method isEmpty() on null object

@i-petro PR welcome! :)

CLI doesn't detect Cococapods installed via rbenv.

Improvements are very welcome!

`config` traversing the entire project paths and reading every single file

It's just unoptimized. We'll welcome any kind of improvements, like caching or better resolution strategy as a PR :)