Michał Pierzchała comments

Results 310 comments of


                                            Michał Pierzchała

Correct highlighting for asymmetric matchers

Hey @grosto, anything we can help with to get this over the line? :)

Fix inconsistency in `rejects.toThrow()`

> Seems like a reasonable change to me 🙂 While I agree everything thrown should be a subclass of Error, we shouldn't make assumptions. 👍 If we can be consistent,...

Fix inconsistency in `rejects.toThrow()`

@SimenB wdyt? My take is we shouldn't drop `rejects`/`resolves` because they were designed to read nicely. I'm fine with adding `.promise` or something next to it

Confusing red color for my custom runner

> removing yellow, green and red SGTM 👍

Standardize file names in packages/jest-snapshot

@hedgerh are you still interested in this contribution? :)

feature: make all (safe) queries return host components

👍🏼

jest version compatibility

Simply because no-one sent a PR to upgrade yet :D RN internally upgraded Jest to 29 recently, so it should be fairly straightforward to upgrade, without being blocked by internal...

jest version compatibility

I'll close this issue, as it's not relevant to the RNTL, but happy to keep the conversation going :)

feat: `userEvent` implementation

I'm ok with this being a separate export. Are there any plans for RTL to merge this library in, provided it's so essential?

Process exit code on test failure

We could add a flag that drives whether tests exit non-zero on failure or not. Would that work for you?