thunder-client-support icon indicating copy to clipboard operation
thunder-client-support copied to clipboard

Conflicting VS Code keybindings to show Thunder Client

Open Haltarys opened this issue 2 years ago • 2 comments

Describe the bug I can't use the keyboard shortcut Ctrl+Shift+R to refactor my code because it is shadowed by this extension.

To Reproduce

  1. Install Thunder client.
  2. Open a text editor (with Ctrl+N for example)
  3. Press Ctrl+Shift+R. The Thunder Client opens instead of showing the refactor pop-up.

Expected behavior I should be able to use the extension AND the refactor keyboard shortcut.

Potential solution Either change the keybinding to another combination altogether or add a when expression to restrict it to a context where it does not shadow any other keybindings.

Platform:

  • OS: Windows 10
  • vscode version: 1.74.2
  • extension version: 2.3.0

Your Team Size Using TC:

Haltarys avatar Jan 08 '23 18:01 Haltarys

Hi @Haltarys Thanks for the feedback, will review it.

You can change the shortcut to different key in keyboard shortcuts view

rangav avatar Jan 08 '23 18:01 rangav

In case it helps, here are some instructions.

The extension uses ctrl+shift+r as the keyboard shortcut, which is the reserved VS Code shortcut for refactor. The extension will override it. To preserve the refactor shortcut, open the shortcut settings by pressing ctrl+shift+p and selecting Open Keyboard Shortcuts (JSON). Then add this as a key binding:

{
  "key": "ctrl+shift+r",
  "command": "editor.action.refactor"
}

FranciscoMoretti avatar Jun 25 '23 09:06 FranciscoMoretti