thunder-client-support icon indicating copy to clipboard operation
thunder-client-support copied to clipboard

Published 20 hours ago • verified publisher icon thunderclient

Request response layout setting no longer respected since 1.18

Open kekonn opened this issue 2 years ago • 10 comments

Describe the bug Since update 1.18, the following setting is no longer respected:

"thunder-client.requestLayout": "Left/Right"

As you can see, my env is set to left/right, but my view is Top/Bottom. Before the update, this was working as intended. Changing the setting also does not change the layout of the request/response pages.

image

To Reproduce Set layout to left/right and open a request.

Expected behavior That the set layout is respected.

Platform:

  • OS: Windows 10
  • vscode version: 1.70.1
  • extension version: 1.18

Solution: If only I knew

kekonn avatar Aug 12 '22 10:08 kekonn

@kekonn did you change any setting in vscode?

that is the default Layout Left/Right, you dont need add any setting for that

rangav avatar Aug 12 '22 11:08 rangav

No I did not change anything. And I know that is the default layout, and yet, the screenshot does not reflect the default layout. So why is that?

kekonn avatar Aug 12 '22 12:08 kekonn

Change setting to top/bottom And see what happens?

after testing change it back to left/right

rangav avatar Aug 12 '22 13:08 rangav

As described in my report, I tried this already. Changing the setting does not have a noticeable effect on the layout.

kekonn avatar Aug 12 '22 16:08 kekonn

did you close the request view and re-open after changing setting?

rangav avatar Aug 12 '22 16:08 rangav

I did a reload window between each setting change.

kekonn avatar Aug 12 '22 16:08 kekonn

is your extension version v1.18.1?

rangav avatar Aug 12 '22 16:08 rangav

share you share your settings screenshot for request layout?

rangav avatar Aug 12 '22 16:08 rangav

image

kekonn avatar Aug 12 '22 17:08 kekonn

thanks for sharing. strange something is not working.

Here are few things you can try

  • Uninstall and re-install extension
  • or downgrade extension to v1.17.1

rangav avatar Aug 12 '22 17:08 rangav

did you still have the issue?

rangav avatar Oct 07 '22 15:10 rangav

Currently the issue is no longer present

kekonn avatar Oct 14 '22 18:10 kekonn

Thanks @kekonn for confirmation 👍

rangav avatar Oct 14 '22 18:10 rangav

Hi @rangav, I'm facing this issue right now, I re-installed Thunder Client, but still the response panel is at the bottom, even changing the configuration to be in the Right position.

manuelvalenzuela avatar Mar 30 '23 17:03 manuelvalenzuela

Hi @manuelvalenzuela can you share screenshot of setting and request view?

and also version of extension used?

rangav avatar Mar 30 '23 17:03 rangav

Hi @rangav, I'm sorry for not answering before. I can't live without Thunder Client :D, so I reinstalled vscode, and everything is working good now! I don't have the screenshot, but was using the latest version of the extension.

manuelvalenzuela avatar Mar 31 '23 07:03 manuelvalenzuela