thunder-client-support
thunder-client-support copied to clipboard
HTTP 1.0 Protocol Support
Is your feature request related to a problem? Please describe. Can not submit a HTTP 1.0 request.
Describe the solution you'd like To be able to select what HTTP Protocol to use when sending HTTP Request
Describe alternatives you've considered Go back and use PostMan, I do not wish to do that, prefer to use Thunder Client
Implementation: Open to any solution but having the option in a combo box to select the version to be used during the http request.
Hi @Marvin-Hart thanks for creating feature request. Will review and add to roadmap.
Thank you.
Here is a mockup of a screen shot. I do not know if it will fit with your U/I flow or not, just spit balling here.
Take care
.
Thanks for sharing, will review it.
Hi @Marvin-Hart, I am using the below http library for requests https://github.com/sindresorhus/got
After contacting them about http 1.0 support, they said the server needs to send the response in http 1.0
see comments here https://github.com/sindresorhus/got/issues/1992
Node.js always defines 1.1 in the request, there's no way around it. However most servers allow those to pass through and respond in 1.0.
While the statement is "partially true", it's not 100% accurate. If a given server is set up to respond 1.0 (server setting for default protocol), it will.However, if that is not the default, you must request 1.0 in the header to get a server to respond in 1.0 otherwise it will be 1.1 You can use a telnet client to manually verify this or use PostMan. Looking at your ticket, it does not look like they are interested in going any further, sad, as it is a very easy fix/enhancement. I will continue to have PostMan installed and use it when I need to. Was hoping to just use one "tool" (yours) for making http request.
Thank you for looking into this. Take care.Marvin
On Sunday, February 27, 2022, 07:56:46 AM CST, Ranga Vadhineni ***@***.***> wrote:
Hi @Marvin-Hart, I am using the below http library for requests https://github.com/sindresorhus/got
After contacting them about http 1.0 support, they said the server needs to send the response in http 1.0 sindresorhus/got#1992
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>
While the statement is "partially true", it's not 100% accurate.
Here's the spec:
The HTTP version number consists of two decimal digits separated by a "." (period or decimal point). The first digit ("major version") indicates the HTTP messaging syntax, whereas the second digit ("minor version") indicates the highest minor version within that major version to which the sender is conformant and able to understand for future communication. The minor version advertises the sender's communication capabilities even when the sender is only using a backwards-compatible subset of the protocol, thereby letting the recipient know that more advanced features can be used in response (by servers) or in future requests (by clients).
My words are 100% accurate. The Got issue was about 1.0 support. Got supports all of 1.0, because Node.js does. It wasn't about setting the version in the request message. This issue wasn't even linked before.
However, if that is not the default, you must request 1.0 in the header to get a server to respond in 1.0 otherwise it will be 1.1
I don't see how this would be an issue with communicating with the server?
it does not look like they are interested in going any further, sad, as it is a very easy fix/enhancement.
If you think it's an easy fix then fork Got and submit a PR here to use the forked version instead. Please do not judge someone's work if you have no idea what you're dealing with. I'm off, cheers.
Not going to get into a philosophy discussion. And my original request, "was" about setting the protocol version in the request. I am not interested in fixing/enhancing others code/libraries, I'm not in the market for that, otherwise I would be writing frameworks/libraries, I have other software commitments to keep up with. Sorry to state, just another typical example of "free software". I'll be happy to continue to pay elsewhere for product that fully functions and where I do not have to go modify it's codebase for core functionality so that I can continue with application development. You all have a wonderful day.
On Tuesday, March 1, 2022, 08:23:51 PM CST, Szymon Marczak ***@***.***> wrote:
While the statement is "partially true", it's not 100% accurate.
Here's the spec:
The HTTP version number consists of two decimal digits separated by a "." (period or decimal point). The first digit ("major version") indicates the HTTP messaging syntax, whereas the second digit ("minor version") indicates the highest minor version within that major version to which the sender is conformant and able to understand for future communication. The minor version advertises the sender's communication capabilities even when the sender is only using a backwards-compatible subset of the protocol, thereby letting the recipient know that more advanced features can be used in response (by servers) or in future requests (by clients).
My words are 100% accurate. The Got issue was about 1.0 support. Got supports all of 1.0, because Node.js does. It wasn't about setting the version in the request message. This issue wasn't even linked before.
However, if that is not the default, you must request 1.0 in the header to get a server to respond in 1.0 otherwise it will be 1.1
I don't see how this would be an issue with communicating with the server?
it does not look like they are interested in going any further, sad, as it is a very easy fix/enhancement.
If you think it's an easy fix then fork Got and submit a PR here to use the forked version instead. Please do not judge someone's work if you have no idea what you're dealing with. I'm off, cheers.
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>
Hi guys, I think the conversation is getting side tracked. I can understand the feelings of both sides, let’s not take it too personal.
leave it to me I will research and find a solution for this issue when I get time.