thunder-client-support icon indicating copy to clipboard operation
thunder-client-support copied to clipboard

💄 Response tab colors

Open davioliveira-dev opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe. The response tab does not have the colors of the current vscode theme, the json response always comes in the default theme (Dark+)

image

I switched themes and this issue continues.

Describe the solution you'd like Just get the current color scheme from vscode and apply to Response tab (on json response)

Describe alternatives you've considered None

Implementation:

davioliveira-dev avatar Jun 29 '21 20:06 davioliveira-dev

Hi @davioliveira-dev Will add this to roadmap.

rangav avatar Jun 29 '21 21:06 rangav

Hi @davioliveira-dev, Looks like vscode did not expose the editor themes to extensions yet

please see this issue in vscode repo https://github.com/Microsoft/vscode/issues/56356

rangav avatar Jan 19 '22 19:01 rangav

for this kind of thing are not sufficient the css variables? in my extension I obtains good result... for example https://github.com/APerricone/vscode-dbf/blob/master/media/style.css

APerricone avatar Jan 19 '22 19:01 APerricone

@APerricone they are not sufficient, I am also using those css variables for extension theme, but for code editor part is not sufficient

If you know how to use them in vscode webviews for code syntax highlighting let me know

rangav avatar Jan 19 '22 21:01 rangav

as we see on microsoft/vscode#56356 they use shiva , I can see on the page it says "But really, any VS Code theme will do" I think you can use window.activeColorTheme. I have not tried

APerricone avatar Jan 20 '22 10:01 APerricone

@APerricone Thanks - Will give it a try and see if it works.

rangav avatar Jan 20 '22 10:01 rangav

This feature is now implemented and published to marketplace, please update to v1.19.0

See all features released https://github.com/rangav/thunder-client-support/releases/tag/v1.19.0

Please let me know your feedback.

rangav avatar Sep 15 '22 18:09 rangav

@rangav how can you do it ? did vscode provide you new API to interact with ?

ejabu avatar Sep 11 '23 13:09 ejabu