thunder-client-support icon indicating copy to clipboard operation
thunder-client-support copied to clipboard

Active Environment selection changes creating Source Control activity

Open cw1934 opened this issue 2 years ago • 7 comments

Every time the active Environment is changed, it results in 2 files showing as having changes in Source Control; the one that used to be active, and the new one that is active. This creates extraneous source control activity and review, and our users' use cases all vary for which Environment they'll be using.

Proposed Solution: Can the Active Environment selection be moved to somewhere in a local file, just referencing the _id of the Active Environment?

cw1934 avatar Aug 03 '23 16:08 cw1934

Thanks @cw1934 for the feedback, Will review it

related issue #448

rangav avatar Aug 04 '23 03:08 rangav

Implementing a solution is the easy part, But I have to make sure it won't confuse other users who don't have this problem

Few Questions:

  • How does the user know when changing the active environment locally without changing git files? Is it the same way currently with a star icon
  • How to provide the user the options in the UI to change active Env locally or real change of active env that modies git
  • How to implement this without confusing existing users.
  • This should work for all the team members?

rangav avatar Aug 04 '23 05:08 rangav

  1. "How does the user know when changing the active environment locally without changing git files? Is it the same way currently with a star icon"
    1. Ideally, I would prefer to have a dropdown that's visible at all times. This is two-fold; so I can see what environment I have selected, and so I can easily change it, both without having to go into an area that's meant more for editing an environment.
  2. "How to provide the user the options in the UI to change active Env locally or real change of active env that modies git"
    1. I can't think of any use-cases where a user would want the change of the Active Environment committed to Git.
  3. "How to implement this without confusing existing users."
    1. If implemented as described in # 1.i, I don't see it as being confusing.
    2. It would help if the environment in the current/old implementation marked as active would be persisted upon update, but I don't think it's crucial.
  4. "This should work for all the team members?"
    1. I'm not sure I understand the question, but think the active environment should always be left to each individual to choose, and not something set team-wide.

cw1934 avatar Aug 04 '23 19:08 cw1934

@rangav Any update on this, or when it will be looked into again? We continue to run into this regularly, and due to the standard modification and merging of files across users, multiple environments' files get saved with ""default": true", resulting in the UI behavior below. We then have to set a third separate environment to Active, and then back to the one we wish to work with in order to be certain the expected variables' values are used in the requests we're making.

image

cw1934 avatar Feb 19 '24 20:02 cw1934

@cw1934

Thanks for the feedback.

Will make this feature request a priority and implement it in around 1 week.

rangav avatar Feb 19 '24 20:02 rangav

@rangav Sounds great, thanks very much. We'll keep an eye out for the release and take a closer look once it's available.

cw1934 avatar Feb 19 '24 21:02 cw1934

@cw1934 Proposed solution - We added a new setting Active Environment Selection, if you set to Save To Local Memory, then no changes will be made to JSON files

Please let me know your feedback. I am planning to publish new update later today.

Screenshot 2024-02-26 at 13 20 40

rangav avatar Feb 21 '24 14:02 rangav

This feature is implemented and published to the marketplace, please update to v2.18.0

See all features in this update https://github.com/rangav/thunder-client-support/releases/tag/v2.18.0

Please test and let me know your feedback.

rangav avatar Feb 26 '24 13:02 rangav