Tom Hughes

Results 6 comments of Tom Hughes

Another example of the same issue: https://discuss.atom.io/t/update-not-working-com-github-atom-shipit-respawns-all-the-time/9819/15

I'll see if I can reproduce it on the machine that had the issue and try pre-creating the log files.

Unfortunately, I haven't been able to reproduce the issue, so it seems like it must be a race. Perhaps the best thing is to intentionally `chown` the files as shown...

This is the same as #236 and #235 , so not necessary (I cleaned it up for #235 and #236)

@nwgh Also have seen this assert when running `node-http2` with `node-apn`: https://github.com/molnarg/node-http2/blob/master/lib/protocol/connection.js#L326 Looking at the call to `this.push` where `moreNeeded` is set, I'm not sure that the assert makes sense...

We've been seeing this even when using `${ghprbActualCommit}`. It seems to happen when the build fails (e.g., compilation failure) and then you push a new commit. The GitHub pull request...