please

please copied to clipboard

enumerate() doesn't work on frozen lists

1

If you try and use built ins like enumerate on lists that get froze (e.g. because they come in scope from a subinclude), then you get a confusing error message...

Tatskaari

`github_repo`: strip `v` prefix if `revision` is any version number

3

`github_repo` currently strips the `v` prefix from the file names in the zip file downloaded from GitHub if `revision` is a semver, since GitHub silently does the same if asked...

chrisnovakovic

Fix visibility check on subrepos

1

Looks like this never got added when we added the subrepo concept. This is of course fixing a bug so we can call it not a breaking change, but it...

peterebden

gentest ignores test results when test returns nonzero

3

I'm running some mocha tests with please. When a test fails, mocha returns `1`. Please interprets this as an error, and doesn't evaluate the results in `$RESULTS_FILE`. Is this intended?...

mibzman

Racy subincludes

1

I've set up a simple Go repo (currently private, sorry, y'all's can't see what I'm up to yet) and am seeing occasional (~1 in 3) failures with `third_party/go/BUILD:3:1: error: name...

peterebden

Add `--out` flag to `plz build`

3

It would be useful to have a `--out` flag e.g. `plz build --out ./dir //src:please` to copy `plz-out/bin/src/please` to `./dir/please`. When set, the [build](https://github.com/thought-machine/please/blob/master/src/please.go#L457) subcommand would loop through all the...

Tatskaari

Allow hiding deprecated config options

2

This marks all the language-specific stuff as deprecated and adds a feature flag that stops asp from getting them on its config object. Hopefully this will start cutting down on...

peterebden

`github_repo` fails when `revision` is a non-semver version number

3

MWE: ``` ## java/snappy-java/BUILD github_repo( name = "snappy-java", repo = "xerial/snappy-java", revision = "v1.1.10.1", hashes = ["b5dcf03f9618bd33fd9f424d9acf711a175aecd690cfca31440954723064d449"], build_file = "snappy-java.build", ) ``` ``` $ plz build //java/snappy-java:snappy-java Build stopped after...

chrisnovakovic

REAPI: Filegroups redownload outputs of other targets

2

When building locally, the following filegroup would be a no-op when we build it: ``` filegroup( name = "foo", srcs = [":bar"], ) ``` Please will build `:bar`, which will...

Tatskaari

Hardcoded assumptions where tools such as `ls` or `mv` live

2

I try to build `please` on [nixos](https://nixos.org), but the `./bootstrap.sh` fails due to built-in assumptions where certain tools live. In nix, different versions of programs can co-exist, but they will...

hzeller