Peter Thornton

Results 21 comments of Peter Thornton

Well, that's not good. Does the list of failing tests include CNP, or just CN tests?

Great catch @peterdschwartz! We will need to dig in on this one.

I think this should say "Component LND is elm3.0 physics and BGC, with C-N-P, nutrient competition via relative demand, CTC decomposition model, and black carbon deposition"

...if it is the default active BGC case, such as what we're using in the v3 water cycle experiments.

@rljacob can you remind me - is the E3SM standard that the components are intended to index their version numbers with major coupled model releases?

I've started a branch to fix this, will push it to my fork for Gautam's review later today.

@WYPZL @bpbond Thanks for your question - it has provided an opportunity for me to revisit both the BGC4.2 code, and my thesis! The comment about all-sided LAI in canopy_et.c...

@rljacob I agree that this can be closed.

@rfiorella I've reviewed these changes, and everything looks good to me. Thanks for catching the bug. Approving.

@peterdschwartz please prioritize integrating this PR.